Skip to content

fix(server): reject empty string list evaluator values#121

Merged
lan17 merged 4 commits intomainfrom
codex/fix-list-empty-values
Mar 17, 2026
Merged

fix(server): reject empty string list evaluator values#121
lan17 merged 4 commits intomainfrom
codex/fix-list-empty-values

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 12, 2026

Summary

  • reject empty-string list entries at list evaluator config validation time
  • defensively filter exact empty strings in the evaluator so legacy invalid configs do not compile into a match-all regex
  • add evaluator and server regression tests for both validation paths

Testing

  • make evaluators-test
  • make server-test
  • make lint
  • make typecheck

Fixes #120

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...uiltin/src/agent_control_evaluators/list/config.py 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lan17 lan17 changed the title fix: reject empty string list evaluator values fix(server): reject empty string list evaluator values Mar 12, 2026
@lan17 lan17 enabled auto-merge (squash) March 14, 2026 06:31
@lan17 lan17 merged commit 2c55d27 into main Mar 17, 2026
6 checks passed
@lan17 lan17 deleted the codex/fix-list-empty-values branch March 17, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListEvaluator: values=[""] builds match-all regex, can cause complete agent denial-of-service. Can be handled from UI/Backend.

3 participants